Ddg graph component #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
everett980
commented
Jun 20, 2019
packages/jaeger-ui/src/components/DeepDependencyGraph/Graph.tsx
Outdated
Show resolved
Hide resolved
everett980
commented
Jun 24, 2019
packages/jaeger-ui/src/components/DeepDependencyGraph/Graph.tsx
Outdated
Show resolved
Hide resolved
tiffon
reviewed
Jun 26, 2019
| super(props); | ||
| const { ddgModel } = props; | ||
| const { distanceToPathElems } = ddgModel; | ||
| this.graphModel = new GraphModel({ ddgModel }); |
There was a problem hiding this comment.
Why not pass the ddgModel in as a param instead of a property on an options object?
There was a problem hiding this comment.
this makes it easier to add more arguments in the future, such as visibilityHeuristic
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements graphComponent that uses
reduxState.currentService.currentOp.currentStart.currentEnd.modelandthis.props.visKeyto render a plexus graph.