Skip to content

Commit

Permalink
feat: publish 2.0
Browse files Browse the repository at this point in the history 
Publish 2.0 to account for the BREAKING CHANGE from #199.
  • Loading branch information
@eventualbuddha
eventualbuddha committed Nov 20, 2021
1 parent 78591e9 commit b62d791
Showing 0 changed files with 0 additions and 0 deletions.

6 comments on commit b62d791

@revelt
Copy link

@revelt revelt commented on b62d791 Nov 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow, npx on my Semaphore CI instance is failing, I'm suspecting 1.2.0 of this program — I get Error: Cannot find module '/home/semaphore/.npm/_npx/d5cad42883f80c/node_modules/lines-and-columns/build/index.mjs'.

Is it possible that somehow beaking 1.2.0 is automatically consumed because of a caret semver (like they have it here) — I tried to dig npx itself but can't find any references via GH searches on public npm org...

I wonder, would it make sense to publish 1.2.1 without esm and named exports? Or somehow to take down the 1.2.0?

@cm8263
Copy link

@cm8263 cm8263 commented on b62d791 Nov 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Author is already looking into the issue, but for the sake of prosperity, we are also having a similar with our Vue linting service.

vue-cli-service lint
node:internal/modules/cjs/loader:488
      throw e;
      ^

Error: Cannot find module 'C:\Users\***\***\***\***\node_modules\lines-and-columns\build\index.mjs'
...

@eventualbuddha
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you were previously using 1.1.6 (which everyone was) then 1.1.9 should work for you. Sorry about that!

@eventualbuddha
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2.1 should also work fine (it's the same as 1.1.9).

@eventualbuddha
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I made another mistake and published 1.1.9 and 1.2.1 with ESM support. This broke any importers that were themselves ESM because they previously would have accessed LinesAndColumns.default. Versions 1.1.10 and 1.2.3 fix that issue and should be equivalent to 1.1.6.

@revelt
Copy link

@revelt revelt commented on b62d791 Nov 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for a quick fix, I can confirm the CI is building, the fixed deps trickled through

Please sign in to comment.