This repository has been archived by the owner on May 21, 2023. It is now read-only.
Don't select a logfile, add an icon, be awesome. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the UI for selecting the logfile entirely, replacing it with a log checker that simply reads all logs. Observe mtimes instead of reading files. Observe mtime of the directory to see if we need to scan the directory again. Pick up all new files automatically.
As per request on CVA forums, support fff lookups. Use a regular expression instead of clumsy split/index parsing to extract the log lines. Add a unit test.
Also open the file using codecs.open(), so that data sanitization doesn't screw up. No idea what happens when someone does russian comments yet.
Also provide clickable links to the kos.cva-eve.org site.
This was referenced Dec 15, 2012
The binary will be 1mb larger, but it's worth it to avoid all encoding issues.
'reset' will reopen the logs directory.
The idea is: - write new tempfile.exe file in temp dir, with updated code objects. - run "tempfile.exe /update KosLookup.exe" and exit - tempfile copies over KosLookup.exe, - run "KosLookup.exe /updated tempfile.exe" and exit - unlinks tempfile.exe
|
My version has drifted considerably from the eve-val version, and I hesitate to merge without any review. |
use the raw mtime of the directory instead of filenames to find the latest revisions. revision 0.8b2
Includes bug fixes from beta
including 'dbhash' is required
Updated chatlog regex to support characters with 3 names (e.g. 'Admiral L Jenkins').
Added test for characters with 3 names (e.g. 'Admiral L Jenkins').
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah. Stuff.
I could make the tailers more efficient by only tailing the latest logfile. I guess. Can't be bothered. This works fine.
All channels are observed, simultaneously. Never need to select a channel.
Opening new channels, and restarting EVE, Will Just Work.
Old KOS lookups will be ignored, no repeated dings on startup anymore.
An Icon! It's an icon of some bells. Because of ding.
Not having a windows ding sound configured no longer causes a crash.
'fff', 'XXX' and 'xxx' all work, this was a request from the CVA folks.
Multiple clients supported. No multiding from multiple log files.