-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does installing tslib actually do anything with esbuild? #2296
Comments
No. You are welcome to compile your code with |
Thanks @evanw for the quick response! Exactly what I needed. I currently am using I will close this issue. |
In case anyone finds this via search and wants a way forward in ES5, we've figured out how to move forward with this for my main project: It's probably a bit hacky, but this relies on two details:
For further enhancements, we've also developed this one: As is, the wrapping package approach unfortunately does not work well with
|
Neither make any sense when building with esbuild See: - evanw/esbuild#2296 (comment) (`tslib` does not make any effect) - https://esbuild.github.io/content-types/#tsconfig-json (`importHelpers` is ignored)
Neither make any sense when building with esbuild See: - evanw/esbuild#2296 (comment) (`tslib` does not make any effect) - https://esbuild.github.io/content-types/#tsconfig-json (`importHelpers` is ignored)
Neither make any sense when building with esbuild See: - evanw/esbuild#2296 (comment) (`tslib` does not make any effect) - https://esbuild.github.io/content-types/#tsconfig-json (`importHelpers` is ignored)
Given that esbuild does not currently support transforming es6+ syntax to es5, and
tslib
main purpose is to add helpers for older es5 browsers etc., does installingtslib
in a project that is usingesbuild
to compile/bundle my TS code even have any impact? Or doestslib
only help if I use thetsc
to compile my TS code, which at that point defeats the purpose of usingesbuild
, correct? Or is there a way to use a combination oftsc
+tslib
+esbuild
to get the best of all worlds?In summary, I guess my question is whether
tslib
actually does anything if I am usingesbuild
for my project?Thanks!
The text was updated successfully, but these errors were encountered: