Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12] time 입력 형식 - 소수점 및 정수 케이스 추가 #11

Merged
merged 3 commits into from
Jan 10, 2025
Merged

[#12] time 입력 형식 - 소수점 및 정수 케이스 추가 #11

merged 3 commits into from
Jan 10, 2025

Conversation

letSumin
Copy link
Collaborator

@letSumin letSumin commented Jan 10, 2025 •
edited
Loading

Changes

  • 기존 시간 입력 형식 HH:mm 외에 정수와 소수점 형식도 지원하도록 fracFormat 함수에 변환 로직을 구현하였습니다.
  • 입력된 시간 형식을 변환하여 HH:mm 형식으로 처리
    • "20" → "20:00"
    • "20.5" → "20:30"
    • "20:30" → 그대로 사용
  • 소수점 입력값은 1자리까지만 허용
    • "20.99" → 예외 발생 - Invalid fraction value: 99. Allowed range is 0-9.

Testing

  • 테스트 코드 추가 - testTimeFractionFormat()

✨ Feat: First time with Kotlin (finally😋)... because typing 19:30 is too much ⏳⏰

@easternkite easternkite linked an issue Jan 10, 2025 that may be closed by this pull request
간편한 소수점 및 정수 입력 추가 #12
Closed
@easternkite easternkite changed the title time 입력 형식 - 소수점 및 정수 케이스 추가 [#12] time 입력 형식 - 소수점 및 정수 케이스 추가 Jan 10, 2025
@letSumin @easternkite
Update src/main/kotlin/com/easternkite/remain/Routing.kt
a55eef0 
에러 케이스 Dooray Hook 발송 처리

Co-authored-by: Lee Dong-Yeon <[email protected]>
easternkite
easternkite approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@easternkite easternkite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소수점 케이스는 fraction으로 나눠서 정밀한 시간으로 계산된 부분이 인상깊었습니다.

다소 복잡할 수 있는 로직을 간단하게 작성해주셔서 감사합니다 😊
고생하셨습니다 ~~

@letSumin letSumin added the enhancement New feature or request label Jan 10, 2025
@letSumin letSumin merged commit 873b3fc into euuungb:main Jan 10, 2025
1 check passed
@letSumin letSumin deleted the feature/simple-time-parser branch January 10, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easternkite easternkite easternkite approved these changes

Assignees

@letSumin letSumin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

간편한 소수점 및 정수 입력 추가
2 participants
@letSumin @easternkite