Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

퇴근 알림 메시지 수정 #1

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

hyun031916
Copy link
Contributor

@hyun031916 hyun031916 commented Dec 30, 2024

  • 케이스 별로 메시지 내용 변경 좀 해보았어요 😁

image

val message = if (duration.toMinutes() < -60) {
"✨ 퇴근시간 ${-hours}시간 ${-minutes}분 초과되었습니다. :joy:"
} else if (duration.toMinutes() < 0) {
"✨ 퇴근시간 ${-minutes}분 초과되었습니다. :joy:"
Copy link
Contributor Author

@hyun031916 hyun031916 Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:joy: 이거 웹훅 갈때 임티 잘 보일지 모르겟네요ㅋㅋㅋ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 두레이 한 번 거쳐서 변환되는거라 잘될 것 같은데요~?
확인 한 번 해볼게여 ㅎㅎ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오~ 잘됩니다! 🎉

Copy link
Collaborator

@easternkite easternkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동작 확인했습니다!!

요건 취향 차이긴 한뎅 if - else 구문은 when 구문으로 처리하는게 저는 이쁘더라구요 ~ㅎㅎ
해당 분기문은 fun getTimeMessageByDuration(duration: Duration) 와 같은 함수로 따로 분리해도 좋을 것 같아요!

첫 pr 감사드립니다 👍 👍
머지할게요 !

@easternkite easternkite merged commit d5d1d5b into euuungb:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants