mockResponse.end(): added callback triggering once end() logic has run. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugef
reviewed
Aug 24, 2021
There was a problem hiding this comment.
AFAIK this PR still doesn't solve your initial problem #6 (comment)
basically I needed the callback argument to be triggered by the mock response end() method :) |
…arameters() and moved it above mockResponse.end() assignment.
GiordanoArman
commented
Aug 24, 2021
…k is provided as argument.
eugef
approved these changes
Aug 27, 2021
|
Looks like this wasn't published in the end? 1.11 does not contain these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eugef, thanks for the help. I added support for the various signatures of end() mentioned on the documentation https://nodejs.org/api/http.html#http_response_end_data_encoding_callback
response.end([data[, encoding]][, callback])I hope my work is neat enough!