Skip to content

Commit

Permalink
Update patch set 3
Browse files Browse the repository at this point in the history
Patch Set 3:

> Patch Set 3: Verified-1
> 
> This breaks completion on mac (which uses bash 3.2):
> 
>   bash-3.2$ source build/envsetup.sh
>   bash: type: compopt: not found
>   bash: type: compopt: not found
>   bash-3.2$ adb <tab>bash: type: _init_completion: not found

mathiasbynens/dotfiles#544
This issue is exactly the same as what we encountered, upgrading bash via brew will resolve this issue. Many built-in commands such as compopt and declare are not available in out-of-box bash in MacOSX.

Perhaps we have to test BASH_VERSION > 4 in envsetup.sh and inform users to upgrade bash to eliminate this issue since 3.x is really outdated.

Patch-set: 3
Reviewer: Gerrit User 1311067 <1311067@85c56323-6fa9-3386-8a01-6480fb634889>
Label: Presubmit-Ready=0
  • Loading branch information
Gerrit User 1311067 authored and Gerrit Code Review committed Jul 15, 2018
1 parent 2cd28a4 commit ef1cc64
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit ef1cc64

Please sign in to comment.