This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Add ability to embed graphite graphs in emails #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astanway what's the best way to get some attention to a pull request? thanks in advance |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This adds a new config option to SMTP_OPTS, 'embed-images' which is a bool. When true, it will download the image content from the graphite host and embed it in the alert email. If fetching the content fails or this setting is false, the old behavior is used.
Rationale
Our organization uses GMail (apps for your domain), which attempts to fetch and cache the images from our graphite host, which is on our company intranet. This results in every graph being a broken image. Additionally, this removes the requirement that recipients be on our company VPN in order to see the graphs (exceptionally helpful on mobile devices).