Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Unit tests (single commit) #27

Merged
merged 3 commits into from
Jun 22, 2013
Merged

Unit tests (single commit) #27

merged 3 commits into from
Jun 22, 2013

Conversation

oxtopus
Copy link
Contributor

@oxtopus oxtopus commented Jun 22, 2013

See #11 for complete history.

@astanway
Copy link
Contributor

One note - can you get rid of the unittest2 and mock in the travis yml file and instead put them in the requirements.txt? No need to squash again.

@astanway
Copy link
Contributor

Sorry, one more thing - in the _addSkip method, you call _addSkip again, which results in another error. Instead, can we do

    def _addSkip(self, test, reason):
        print reason

astanway pushed a commit that referenced this pull request Jun 22, 2013
Merge pull request #27 from oxtopus/algorithms_tests-squashed
cc90e3c 
Unit tests (single commit)
@astanway astanway merged commit cc90e3c into etsy:master Jun 22, 2013
@oxtopus
Copy link
Contributor Author

oxtopus commented Jun 22, 2013

Thanks!

@astanway
Copy link
Contributor

No problem. Setting up Travis as we speak.

jconway325 pushed a commit to jconway325/algo_skylne that referenced this pull request Jul 24, 2019
@oxtopus
Fixup _addSkip() - etsy/skyline#27 (comment)
e346966
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxtopus @astanway