Add TCP option for dig plugin. (ansible-collections#7343)

* Add TCP option for dig plugin. * Add changelog of dig tcp option * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: s-miyachi <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
etrombly · Oct 25, 2023 · e08efa9 · e08efa9
1 parent 8bbd2b6
commit e08efa9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/changelogs/fragments/7343-dig-tcp-option.yml b/changelogs/fragments/7343-dig-tcp-option.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - dig lookup plugin - add TCP option to enable the use of TCP connection during DNS lookup (https://github.com/ansible-collections/community.general/pull/7343).
diff --git a/plugins/lookup/dig.py b/plugins/lookup/dig.py
@@ -70,6 +70,11 @@
           - "Class."
         type: str
         default: 'IN'
+      tcp:
+        description: Use TCP to lookup DNS records.
+        default: false
+        type: bool
+        version_added: 7.5.0
     notes:
       - ALL is not a record per-se, merely the listed fields are available for any record results you retrieve in the form of a dictionary.
       - While the 'dig' lookup plugin supports anything which dnspython supports out of the box, only a subset can be converted into a dictionary.
@@ -329,6 +334,7 @@ def run(self, terms, variables=None, **kwargs):
         flat = self.get_option('flat')
         fail_on_error = self.get_option('fail_on_error')
         real_empty = self.get_option('real_empty')
+        tcp = self.get_option('tcp')
         try:
             rdclass = dns.rdataclass.from_text(self.get_option('class'))
         except Exception as e:
@@ -375,6 +381,8 @@ def run(self, terms, variables=None, **kwargs):
                     fail_on_error = boolean(arg)
                 elif opt == 'real_empty':
                     real_empty = boolean(arg)
+                elif opt == 'tcp':
+                    tcp = boolean(arg)
 
                 continue
 
@@ -408,7 +416,7 @@ def run(self, terms, variables=None, **kwargs):
 
         for domain in domains:
             try:
-                answers = myres.query(domain, qtype, rdclass=rdclass)
+                answers = myres.query(domain, qtype, rdclass=rdclass, tcp=tcp)
                 for rdata in answers:
                     s = rdata.to_text()
                     if qtype.upper() == 'TXT':
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		minor_changes:
		- dig lookup plugin - add TCP option to enable the use of TCP connection during DNS lookup (https://github.com/ansible-collections/community.general/pull/7343).