Update make commands to set no-TTY flag

[earmenda]

Closes #375

Code Changes

• Set --no-TTY for targets called within github actions

Steps to Confirm

• Confirm this PR includes test output

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation Updated

Description Of Changes

Docker Compose version 2.2.2 used to guess whether to set the no-TTY flag when running the docker compose run command. As of 2.2.3 the flag is never set for you.
See the related PR - docker-compose-9035

To understand the flag better, see the following:
https://stackoverflow.com/questions/30137135/confused-about-docker-t-option-to-allocate-a-pseudo-tty

What I think was happening before was that when github actions ran our docker compose run command it would set the no-TTY flag for us, and when running locally it would not.

I can't say i 100% understand how this flag works or why we don't see output without it but setting it should be the equivalent of our previous behavior.

[earmenda]

Related issue:
actions/runner-images#5022

[earmenda]

Triggered a test failure through this PR and verified we see output now!
https://github.com/ethyca/fides/runs/5298397726

[earmenda]

The only weird thing about this change is that when you run make pytest-unit it now uses the --no-TTY flag locally when it didnt use to.

This doesn't change the functionality but the interaction with the terminal isn't the same. The new output is no longer color coded and formatting might be a little different.

with -T:

without -T:

This doesn't concern me too much though because we don't really use these make targets as part of our dev process. We could write some logic so emulate the old behavior but I don't think it is worth it.

[SteveDMurphy]

Great find @earmenda ! 🙌🏽

[PSalant726]

Nice work finding this - do you have a link to a GH actions change or announcement that confirms they disable TTY mode in runners now?

We should preserve TTY mode in local terminals. Can we include this flag only in the pr_checks.yml file?

[earmenda]

@PSalant726 I made the changes you suggested. We now only set CI_ARGS when the CI environment variable is set. This is based on this - https://docs.github.com/en/actions/learn-github-actions/environment-variables

[PSalant726]

LGTM!