This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
[WIP] Push syncing pss #971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2018
nolash
force-pushed
the
pss-handler-refactor-depth
branch
from
10def86 to
11f1528
Compare
2 tasks
nolash
force-pushed
the
pss-handler-refactor-depth
branch
from
a46ac96 to
b13b05c
Compare
zelig
force-pushed
the
push-syncing-pss
branch
from
644ffab to
f5327ab
Compare
zelig
requested review from
fjl,
gluk256,
holisticode,
janos,
acud and
zsfelfoldi
as code owners
zelig
removed request for
fjl,
nonsense,
holisticode,
zsfelfoldi and
gluk256
zelig
force-pushed
the
push-syncing-pss
branch
from
f5327ab to
30157fd
Compare
|
this now works as expected with current master. tags and db interface needs to be replaced according to #1028 |
|
blocked by #987 |
|
obsoleted in favour of #1323 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push sync implemented as described in https://hackmd.io/ffBjSu8RTyKikvRO7bYrzA#
temporary PR for debugging
try running this and see that often the neighbourhood sends are not delivered for some reason.
if you change this line https://github.com/ethersphere/go-ethereum/pull/971/files#diff-f499799c287a40bb411f478314862498R219
to
chunkCnt := 1it always works