Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

swarm/network: remove spammy log line #1011

Closed
wants to merge 1 commit into from
Closed

swarm/network: remove spammy log line #1011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swarm/network/stream/delivery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func (d *Delivery) RequestFromPeers(ctx context.Context, req *network.Request) (
}
sp = d.getPeer(id)
if sp == nil {
log.Warn("Delivery.RequestFromPeers: peer not found", "id", id)
//log.Warn("Delivery.RequestFromPeers: peer not found", "id", id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets leave this. this warning occurring too many times is indicating a bug.

Copy link
Contributor Author

@nonsense nonsense Nov 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is a bug, but this is a very spammy log line, and it is not helpful.

screen shot 2018-11-21 at 12 48 53

400k times for a single peer. Users are complaining that this is filling their disks with logs, and rightly so.

I am currently looking into it, but we should not have another release with this spammy log.

The peer in question in the logs is actually present in the peer list, so I am not sure why d.getPeer(id) is returning nil.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a bug and we just silently "ignore" it, then we should open an issue to investigate it and find a solution.

return true
}
spID = &id
Expand Down