Errant console.log call

[cte]

Describe the bug
A console.log was left in a common code path for contract interaction:
https://github.com/ethers-io/ethers.js/blob/v5.5.4/packages/abi/src.ts/interface.ts#L418

Would it be more appropriate to use an internal logger? I'm not sure why anything needs to be logged given that the error is already being propagated.

Reproduction steps
Here's an example of what is logged to my shell when I'm attempting to discover which interfaces a particular contract implements via ERC165 (i.e. contract.supportsInterface(...)):

Error: no matching error (argument="sighash", value="0x734e6e1c", code=INVALID_ARGUMENT, version=abi/5.5.0)
    at Logger.makeError (/node_modules/@ethersproject/logger/src.ts/index.ts:225:28)
    at Logger.throwError (/node_modules/@ethersproject/logger/src.ts/index.ts:237:20)
    at Logger.throwArgumentError (/node_modules/@ethersproject/logger/src.ts/index.ts:241:21)
    at Interface.getError (/node_modules/@ethersproject/abi/src.ts/interface.ts:269:20)
    at Interface.decodeFunctionResult (/node_modules/@ethersproject/abi/src.ts/interface.ts:413:44)
    at Contract.<anonymous> (/node_modules/@ethersproject/contracts/src.ts/index.ts:392:44)
    at step (/node_modules/@ethersproject/contracts/lib/index.js:48:23)
    at Object.next (/node_modules/@ethersproject/contracts/lib/index.js:29:53)
    at fulfilled (/node_modules/@ethersproject/contracts/lib/index.js:20:58)
    at runMicrotasks (<anonymous>) {
  reason: 'no matching error',
  code: 'INVALID_ARGUMENT',
  argument: 'sighash',
  value: '0x734e6e1c'

Environment:
RPC calls are running exclusively against Geth.

Search Terms

• console.log
• output

[ricmoo]

Yes, that should definitely be removed. I'm working on the next minor bump now and will add it for inclusion in that.

Thanks! :)

[ricmoo]

Fixed in v5.6.

Thanks! :)