Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in doc for ContractFactory #2257

Closed
ASmallPotato opened this issue Nov 1, 2021 · 1 comment
Closed

Typo in doc for ContractFactory #2257

ASmallPotato opened this issue Nov 1, 2021 · 1 comment
Labels
documentation Documentation related issue.

Comments

@ASmallPotato
Copy link

In the documentation, the description for ContractFactory's connect method said it returns a ContractFactory. However the signature indicate that it returns a Contract, it should be ContractFactory.

related section

_property: contractFactory.connect(signer) => [[Contract]] @<ContractFactory-connect>
Returns a **new instance** of the ContractFactory with the same //interface//
and //bytecode//, but with a different //signer//.

@ASmallPotato ASmallPotato added the investigate Under investigation and may be a bug. label Nov 1, 2021
@ricmoo ricmoo added documentation Documentation related issue. and removed investigate Under investigation and may be a bug. labels Nov 30, 2021
@ricmoo
Copy link
Member

ricmoo commented Dec 1, 2021

Fixed!

Thanks! :)

@ricmoo ricmoo closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

No branches or pull requests

2 participants