Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building locally #1153

Closed
fvictorio opened this issue Nov 13, 2020 · 5 comments
Closed

Building locally #1153

fvictorio opened this issue Nov 13, 2020 · 5 comments
Labels
documentation Documentation related issue.

Comments

@fvictorio
Copy link

What is the recommended way to build and link this project locally? I looked around for a contributing.md or developing.md but didn't find one.

I'm trying to debug something in hardhat and I would like to be able to use a locally linked version with sourcemaps enabled. Is this possible?

@ricmoo
Copy link
Member

ricmoo commented Nov 13, 2020

If you use npm install on the root package it will hoist and build the rats nest of node_modules in each sub-package. Whenever you modify a package.json, you will need to re-run install.

Then you can just use npm link in the packages/ethers to create the local link and link into your package.

I think. I haven’t ever tried that last part, but should work. Let me know. :)

@ricmoo ricmoo added the documentation Documentation related issue. label Nov 13, 2020
@fvictorio
Copy link
Author

I tried that out but the linking didn't work for me. I also tried running the tests to check a change but the build script failed. I think it would be useful to have a basic guide on how to build, modify and test locally, and to validate that guide in a fresh clone (I can help with the validation if you want).

@ricmoo
Copy link
Member

ricmoo commented Feb 5, 2021

I've tweaked the docs a bit and tested on a new host. Can you try out the steps here and let me know if you still have any issue building it yourself?

@ricmoo
Copy link
Member

ricmoo commented Feb 25, 2021

I'm going to close this now, but if you still have issues linking locally, please re-open.

Thanks! :)

@fvictorio
Copy link
Author

It just took me two months but: yes, it works fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

No branches or pull requests

2 participants