-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about merging this as is and creating a new PR for other tests?
It doesn't work on 4, I'm fine skipping that. |
That's ok, will push asap. |
14754ff
to
80516c4
Compare
@axic Ok, done. Any insight on the So does it make sense to add tests for this respectively add the checks to existing tests? |
80516c4
to
df43db0
Compare
@axic Had a linting error, pushed again. |
I think it tries to extract the size needed to encode the value? Not sure. |
Fixes #21 (partly) and #20