This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Enforce buffer inputs for account methods #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
force-pushed
the
enforce-hex-value-format
branch
from
11fc1c1 to
78626a4
Compare
cgewecke
force-pushed
the
enforce-buffer-accounts
branch
from
5f26449 to
f3192cf
Compare
cgewecke
force-pushed
the
enforce-buffer-accounts
branch
from
f3192cf to
54bebef
Compare
holgerd77
approved these changes
Apr 24, 2020
| @@ -183,7 +180,7 @@ export const privateToPublic = function(privateKey: Buffer): Buffer { | |||
| * Converts a public key to the Ethereum format. | |||
| */ | |||
| export const importPublic = function(publicKey: Buffer): Buffer { | |||
| publicKey = toBuffer(publicKey) | |||
| assertIsBuffer(publicKey) | |||
| if (publicKey.length !== 64) { | |||
| publicKey = secp256k1.publicKeyConvert(publicKey, false).slice(1) | |||
| } | |||
There was a problem hiding this comment.
Ok, account.ts changes look good.
|
Ah sorry @holgerd77 I had this pointed at #241 so that the diff was clearer. Will re-open |
|
Oh, sorry, didn't notice |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PR builds on & targets #241)
Part of #172 Breaking API Changes
accounts.tsisPrecompiledis ignored here because it's targeted for removal in #242