Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: add yargs as dev dep for t8n #3852

Merged
merged 2 commits into from
Jan 28, 2025
Merged

vm: add yargs as dev dep for t8n #3852

merged 2 commits into from
Jan 28, 2025

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Jan 28, 2025

Adds the yarg package to dev dependencies of VM. I just launched t8n and t8n complained about not finding the yargs package. Also adds t8n back to coverage.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (7fafd41) to head (2d54db8).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.41% <ø> (ø)
blockchain 85.38% <ø> (ø)
client 66.00% <ø> (ø)
common 89.81% <ø> (ø)
devp2p 75.66% <ø> (ø)
ethash 80.80% <ø> (ø)
evm 68.46% <ø> (ø)
genesis 99.84% <ø> (ø)
mpt 57.08% <ø> (ø)
rlp 69.70% <ø> (ø)
statemanager 69.60% <ø> (ø)
tx 79.75% <ø> (ø)
util 76.91% <ø> (ø)
vm 57.31% <ø> (ø)
wallet 82.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 2eb4c44 into master Jan 28, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants