Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Node Nightly CI jobs #3846

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Fix broken Node Nightly CI jobs #3846

merged 7 commits into from
Jan 24, 2025

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Jan 23, 2025

This removes Node 18 from the Node versions run by the Node Nightly ci jobs (since only 18 is failing and it's been deprecated and we no longer officially support it).

Also rewrites client/test/rpc/websocket.spec.ts so the test should be less flaky.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.28%. Comparing base (020ceec) to head (6e0d84d).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.20% <ø> (ø)
blockchain 82.92% <ø> (ø)
client 72.91% <ø> (ø)
common 89.82% <ø> (ø)
devp2p 71.18% <ø> (ø)
evm 64.59% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 51.77% <ø> (+0.03%) ⬆️
rlp 95.11% <ø> (ø)
statemanager 67.05% <ø> (ø)
tx 75.32% <ø> (ø)
util 72.41% <ø> (ø)
vm 57.33% <ø> (ø)
wallet 78.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member

CI failed, test-all-browser:

 FAIL   chrome  test/api/muirGlacier/index.spec.ts [ test/api/muirGlacier/index.spec.ts ]
TypeError: Failed to fetch dynamically imported module: http://localhost:63315/home/runner/work/ethereumjs-monorepo/ethereumjs-monorepo/packages/vm/test/api/muirGlacier/index.spec.ts?import&browserv=1737703646589

Client test:

Serialized Error: { errors: [ { stack: 'Error: connect ECONNREFUSED ::1:12345\n    at createConnectionError (node:net:1652:14)\n    at afterConnectMultiple (node:net:1682:16)', message: 'connect ECONNREFUSED ::1:12345', errno: -111, code: 'ECONNREFUSED', syscall: 'connect', address: '::1', port: 12345, constructor: 'Function<Error>', name: 'Error', toString: 'Function<toString>' }, { stack: 'Error: connect ECONNREFUSED 127.0.0.1:12345\n    at createConnectionError (node:net:1652:14)\n    at afterConnectMultiple (node:net:1682:16)', message: 'connect ECONNREFUSED 127.0.0.1:12345', errno: -111, code: 'ECONNREFUSED', syscall: 'connect', address: '127.0.0.1', port: 12345, constructor: 'Function<Error>', name: 'Error', toString: 'Function<toString>' } ], code: 'ECONNREFUSED' }
This error originated in "test/rpc/websocket.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "server without any auth headers". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great cleanup on the websocket tests!

@acolytec3 acolytec3 merged commit 2b44dff into master Jan 24, 2025
41 checks passed
@acolytec3 acolytec3 deleted the fix-node-nightly branch January 24, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants