-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken Node Nightly CI jobs #3846
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
CI failed,
Client test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great cleanup on the websocket tests!
This removes Node 18 from the Node versions run by the Node Nightly ci jobs (since only 18 is failing and it's been deprecated and we no longer officially support it).
Also rewrites
client/test/rpc/websocket.spec.ts
so the test should be less flaky.