vm: adjust test runner with verkle state management #3716
+171
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
What is the status of this? |
|
I'm still using it to try and run the verkle test fixtures but it's not ready for merging. We still have some blockers when running verkle at genesis that I don't have a solution for. Notably, if verkle is at genesis, we have to figure out how to hack in an execution witness or else relax the requirements for creating verkle blocks. I have ideas but none are really elegant or don't introduce tech debt we don't want |
Merged
acolytec3
force-pushed
the
vm/verkle-testing
branch
from
cc351fd to
ee00f50
Compare
…ereumjs-monorepo into vm/verkle-testing
Merged
…ereumjs-monorepo into vm/verkle-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the test runner so that a
stateManageroption can be passed in order to use a non-default (default being MerkleStateManager) state manager (for now, the only other option isstateManager=verkle, which will instantiate a StatefulVerkleStateManager to run the requested tests.