Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpcDebug stack collection to all rpc modules #3127

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Oct 31, 2023

Currently, the ability to collect stack traces for rpc modules is not applied to all modules. This change adds it to all rpc modules. Also see #3125 which will make the rpcDebug functionality and cli option more consistent in behavior.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3127 (dc5f459) into master (9f91d22) will decrease coverage by 1.41%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 92.27% <ø> (ø)
client ?
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.93% <ø> (ø)
rlp ?
statemanager 90.13% <ø> (ø)
trie 89.72% <ø> (-0.34%) ⬇️
tx ?
util 87.53% <ø> (ø)
vm 76.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 6795fa6 into master Oct 31, 2023
@scorbajio scorbajio deleted the rpc-stack-collection branch October 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants