Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monorepo: More LRU updates and ESM Fixes #2809

Merged
merged 38 commits into from
Jun 22, 2023
Merged

Monorepo: More LRU updates and ESM Fixes #2809

merged 38 commits into from
Jun 22, 2023

Conversation

holgerd77
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Merging #2809 (5af888b) into master (3c1c835) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.29% <ø> (ø)
blockchain 92.50% <100.00%> (-0.15%) ⬇️
client 87.10% <ø> (+0.01%) ⬆️
common 97.09% <100.00%> (ø)
devp2p 86.58% <ø> (ø)
ethash ∅ <ø> (∅)
evm 66.78% <ø> (ø)
rlp ?
statemanager 86.35% <ø> (ø)
trie 90.01% <100.00%> (-0.01%) ⬇️
tx 95.87% <ø> (ø)
util 85.31% <ø> (ø)
vm 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77 added 23 commits June 22, 2023 10:31
@holgerd77
Fix yaml file
f943000
@holgerd77
Util: switch to type commonjs for main package.json, skip provider te…
00df5c1 
…sts, re-add to browser CI run
@holgerd77
Common: switch to type commonjs in package.json
6cf9f04
@holgerd77
Tx: switch to type commonjs in package.json
73914cb
@holgerd77
Trie: switch to type commonjs in package.json, require fixes, skip st…
a5f9044 
…ream.spec.ts, activate in browser CI workflow
@holgerd77
Add missing import path
b1b96e1
@holgerd77
Bring back webdriverio for additional browser testing flexibility
082dcd6
@holgerd77
Rebuild package-lock.json
61c6132
@holgerd77
Block: fixes and re-add to browser CI workflow
be491e2
@holgerd77
Blockchain: fixes
5223507
@holgerd77
Blockchain: update LRU cache from v7 to v10
6300c6c
@holgerd77
Rebuild package-lock.json
a4e835c
@holgerd77
Blockchain: move Consensus interface to types.ts (fixes Blockchain te…
bd5ef2a 
…st run so might be something generally quirky and generally can't hurt anyhow)
@holgerd77
Genesis: require -> import (only temporary, will refactored anyhow, t…
2345581 
…hen: no central JSON-distribution-file)
@holgerd77
Blockchain: reactivate browser test CI workflow
1d97c59
@holgerd77
Wallet fixes
679a210
@holgerd77
Wallet: update uuid from v8 to v9, require -> import, added @types/uuid
007d11d
@holgerd77
Rebuild package-lock.json
94dc5b4
@holgerd77
Wallet: move main source to dedicated file, index.ts -> wallet.ts
0f14664
@holgerd77
Wallet: rework Wallet to have its own wallet.ts file and a distributi…
2a09063 
…ng index.ts file
@holgerd77
Wallet: add vitest.config.browser.ts, exclude index.spec.ts, add to C…
a478c4d 
…I browser test workflow
@holgerd77
StateManager: switch type to commonjs in package.json, add vitest.con…
a1a23b1 
…fig.browser.ts file, exlude two failing test files, activate CI browser test workflow
@holgerd77
Util: test other browser test provider and browser in CI
602bd74
@holgerd77 holgerd77 force-pushed the more-lru-updates-and-esm-fixes branch from ac7e004 to 602bd74 Compare June 22, 2023 10:50
@acolytec3 acolytec3 mentioned this pull request Jun 22, 2023
Closed
g11tech
g11tech previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

acolytec3
acolytec3 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved already :-)

@acolytec3 acolytec3 merged commit e0282e3 into master Jun 22, 2023
@acolytec3 acolytec3 deleted the more-lru-updates-and-esm-fixes branch June 22, 2023 20:01
@jochem-brouwer
Copy link
Member

🎉

@holgerd77
Copy link
Member Author

We are getting there. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

@g11tech g11tech g11tech left review comments

Assignees
No one assigned
Labels
package: monorepo PR state: needs review type: refactor type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holgerd77 @jochem-brouwer @acolytec3 @g11tech