Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove touched height map #2589

Closed

Conversation

acolytec3
Copy link
Contributor

Experiment in removing the touchedHeight map

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #2589 (48b8fb3) into vm-diff-based-touched-account-checkpointing (bde9b8a) will increase coverage by 1.81%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.13% <ø> (ø)
blockchain 90.40% <ø> (ø)
client 87.68% <ø> (?)
common 95.82% <ø> (ø)
devp2p 91.84% <ø> (ø)
ethash ∅ <ø> (?)
evm ?
rlp ?
statemanager 89.61% <ø> (?)
trie 90.36% <ø> (ø)
tx 94.16% <ø> (ø)
util 84.50% <ø> (ø)
vm 84.20% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member

Add test all hardforks? Cannot do this on mobile I think

@jochem-brouwer
Copy link
Member

I added this due to this reason: #2581 (comment)

@acolytec3
Copy link
Contributor Author

I added this due to this reason: #2581 (comment)

Ah, I missed the significance of this before. My PR already is failing on a couple of revert tests (like the exact scenario you outlined). Will close here.

@acolytec3 acolytec3 closed this Mar 14, 2023
@holgerd77 holgerd77 deleted the map-reduction branch March 16, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants