allforks: Allow genesis to be post merge #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
added
PR state: WIP
package: block
package: blockchain
package: common
type: test all hardforks
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
force-pushed
the
merge-at-genesis
branch
from
28083fb to
41b470f
Compare
g11tech
force-pushed
the
merge-at-genesis
branch
from
41b470f to
50cdbe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the top of other withdrawal fixes for #2498
since this needs its own separate consideration, however this branch can be used to continue fixing further withdrawal hive fixes
We have been having various oddies regarding merge at genesis, where we didn't allow genesi block to attain merge, and forcefully putting merge hf just after genesis hardforks. So even with shanghai genesis we would get merge hf at block 1, and other issues which would not be as clear to the developer.
Post discussions with @acolytec3 while hive debugging, we concluded that its ok or rather desirable to allow genesis to attain merge.
This PR allows merge at genesis as well as skips some validations for PoS genesis which hive post merge shanghai genesis were failing.