Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename rlp package to @ethereumjs/rlp #2092

Merged
merged 15 commits into from
Aug 4, 2022
Merged

chore: rename rlp package to @ethereumjs/rlp #2092

merged 15 commits into from
Aug 4, 2022

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 3, 2022

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2092 (516100d) into master (c7a8bec) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 83.81% <100.00%> (?)
blockchain 80.54% <100.00%> (ø)
client 78.22% <100.00%> (ø)
common 95.31% <ø> (ø)
devp2p 82.56% <100.00%> (+0.12%) ⬆️
ethash 90.81% <100.00%> (?)
evm 40.94% <ø> (ø)
rlp 90.47% <ø> (ø)
statemanager 84.55% <100.00%> (ø)
trie 81.94% <100.00%> (+0.58%) ⬆️
tx 92.20% <100.00%> (ø)
util 87.22% <100.00%> (ø)
vm 78.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faustbrian faustbrian marked this pull request as ready for review August 3, 2022 02:19
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
@holgerd77 holgerd77 added type: refactor package: rlp target: master Work to be done towards master branch labels Aug 3, 2022
@holgerd77
Copy link
Member

Hi there, just merged #2093, hope this didn't interfere too much with your imminent work here.

@faustbrian
Copy link
Contributor Author

Merged and sorting applied

@holgerd77
Copy link
Member

Ok, let me know when this is ready for review and merge.

Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
Copy link
Contributor Author

@holgerd77 should be good to go other than the dangling client test which seems to hang on randomly on every other commit on every PR

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM, thanks a lot!

Will merge.

@holgerd77 holgerd77 merged commit 79163c0 into ethereumjs:master Aug 4, 2022
@faustbrian faustbrian deleted the rlp-scoping branch August 4, 2022 08:31
@holgerd77
Copy link
Member

This is missing some doc updates in the README (I first-round-spotted the title and the install command), should be side added on some other PR or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: rlp target: master Work to be done towards master branch type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RLP package not scoped
3 participants