-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename rlp
package to @ethereumjs/rlp
#2092
Conversation
Signed-off-by: Brian Faust <[email protected]>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Hi there, just merged #2093, hope this didn't interfere too much with your imminent work here. |
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
Merged and sorting applied |
Ok, let me know when this is ready for review and merge. |
Signed-off-by: Brian Faust <[email protected]>
Signed-off-by: Brian Faust <[email protected]>
@holgerd77 should be good to go other than the dangling client test which seems to hang on randomly on every other commit on every PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM, thanks a lot!
Will merge.
This is missing some doc updates in the README (I first-round-spotted the title and the install command), should be side added on some other PR or so. |
package.json
files #2093 first so that the sorting can be applied here too since the name changed so the package will move up in sorting