Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethers v5.5.1 Hardhat E2E Test #1534

Closed
wants to merge 1 commit into from
Closed

Conversation

holgerd77
Copy link
Member

This is a test if Harhat E2E tests are passing again with the Ethers v5.5.1 patch release from today - see ethers-io/ethers.js#2190 (comment) , do not merge!

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1534 (94aaa90) into master (e001ba0) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 86.14% <ø> (-0.14%) ⬇️
blockchain 82.46% <ø> (ø)
client 79.45% <ø> (+0.68%) ⬆️
common 94.37% <ø> (+0.10%) ⬆️
devp2p 83.01% <ø> (+0.16%) ⬆️
ethash 90.76% <ø> (ø)
tx 87.47% <ø> (+0.12%) ⬆️
vm 80.21% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

E2E Tests are passing after the v5.5.1 Ethers update, will close. 😄

@holgerd77 holgerd77 closed this Oct 20, 2021
@holgerd77 holgerd77 deleted the ethers-v551-hardhat-e2e-test branch October 20, 2021 13:17
@holgerd77 holgerd77 restored the ethers-v551-hardhat-e2e-test branch October 20, 2021 13:18
@holgerd77 holgerd77 reopened this Oct 20, 2021
@holgerd77
Copy link
Member Author

Actually will reopen for now, otherwise the CI runs are not visible for reference any more (so please keep open for another 1-2 days).

@holgerd77
Copy link
Member Author

This can be closed now.

@holgerd77 holgerd77 closed this Oct 27, 2021
@holgerd77 holgerd77 deleted the ethers-v551-hardhat-e2e-test branch October 27, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant