Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier lint #1256

Closed
wants to merge 3 commits into from
Closed

Fix prettier lint #1256

wants to merge 3 commits into from

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented May 14, 2021

This PR runs lint:fix with prettier 2.3.0

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1256 (494ce2e) into master (a03be0f) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 82.51% <ø> (+0.31%) ⬆️
blockchain 84.42% <ø> (ø)
client 84.54% <ø> (ø)
common 88.61% <ø> (+0.49%) ⬆️
devp2p 83.92% <ø> (+0.31%) ⬆️
ethash 82.08% <ø> (ø)
tx 88.74% <ø> (+0.12%) ⬆️
vm 86.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Hi @ryanio, thanks for working this out with the analysis why the linting went wrong at some point, cool! 😄

I am very much afraid that this will get a big hazzle to rebase this huge #1148 EIP-1559 PR on top of this though. I remember that I had such a situation before and it gets super laborious to manually fuddle all the changes together with the correct linting on a rebase, and this will likely break many times before done so this is likely not worth the effort.

I will put this on "blocked" for now, let's please either wait until the 1559-PR is merged - this should just be days away - and then do the linting on top and for these few days ignore the broken linting on the other open PRs. Or we could alternatively also open this PR towards the 1559 branch.

@ryanio
Copy link
Contributor Author

ryanio commented May 17, 2021

for sure, thanks, no problem. this would be easy to add as an additional commit to an existing PR if that would be better, just run npm i && npm run lint:fix at root.

@ryanio ryanio force-pushed the fix-prettier-lint branch from f6f4db1 to bc54585 Compare May 19, 2021 15:42
@holgerd77
Copy link
Member

I now had integrated the linting fixes into the 1559 PR, so not sure if this (or parts from here) still needs to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants