Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM, Block: large ChainID ecrecover fixes #1139

Merged
merged 2 commits into from
Mar 5, 2021
Merged

VM, Block: large ChainID ecrecover fixes #1139

merged 2 commits into from
Mar 5, 2021

Conversation

holgerd77
Copy link
Member

Two more fixes when using ecrecover on large chain IDs:

  • VM ECRECOVER precompile
  • Block cliqueSigner() address recovery

@codecov
Copy link

codecov bot commented Mar 5, 2021 •
edited
Loading

Codecov Report

Merging #1139 (7353155) into master (2e77693) will increase coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client 87.07% <ø> (+0.22%) ⬆️
common ?
devp2p ?
ethash ?
tx ?
vm 81.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 force-pushed the large-chain-id-support branch from b6babb0 to 01b5e3c Compare March 5, 2021 18:05
@holgerd77 holgerd77 force-pushed the large-chain-id-support branch from 01b5e3c to 0628acc Compare March 5, 2021 18:07
@holgerd77
Copy link
Member Author

Rebased this and fixed a linting error.

ryanio
ryanio approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryanio ryanio merged commit c8908ea into master Mar 5, 2021
@ryanio ryanio deleted the large-chain-id-support branch March 5, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

@cgewecke cgewecke Awaiting requested review from cgewecke

@jochem-brouwer jochem-brouwer Awaiting requested review from jochem-brouwer

Assignees
No one assigned
Labels
package: block package: vm PR state: needs review type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerd77 @ryanio