tx: hardhat E2E error msg fix

ethereumjs · Oct 25, 2021 · 14cdd66 · 14cdd66 · github-actions · Oct 25, 2021
1 parent e1ec6a0
commit 14cdd66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/packages/client/test/rpc/eth/sendRawTransaction.spec.ts b/packages/client/test/rpc/eth/sendRawTransaction.spec.ts
@@ -52,11 +52,7 @@ tape(`${method}: call with invalid tx (wrong chain ID)`, async (t) => {
     '0x02f9010a82066a8001018402625a0094cccccccccccccccccccccccccccccccccccccccc830186a0b8441a8451e600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000f85bf859940000000000000000000000000000000000000101f842a00000000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000060a701a0afb6e247b1c490e284053c87ab5f6b59e219d51f743f7a4d83e400782bc7e4b9a0479a268e0e0acd4de3f1e28e4fac2a6b32a4195e8dfa9d19147abe8807aa6f64'
   const req = params(method, [txData])
 
-  const expectRes = checkError(
-    t,
-    PARSE_ERROR,
-    'serialized tx data could not be parsed (The chain ID does not match the chain ID of Common)'
-  )
+  const expectRes = checkError(t, PARSE_ERROR, 'serialized tx data could not be parsed')
   await baseRequest(t, server, req, 200, expectRes)
 })
 

diff --git a/packages/tx/src/eip2930Transaction.ts b/packages/tx/src/eip2930Transaction.ts
@@ -403,7 +403,8 @@ export default class AccessListEIP2930Transaction extends BaseTransaction<Access
    */
   public errorStr() {
     let errorStr = this._getSharedErrorPostfix()
-    errorStr += ` gasPrice=${this.gasPrice} accessList=${this.accessList.length} (size)`
+    // Keep ? for this.accessList since this otherwise causes Hardhat E2E tests to fail
+    errorStr += ` gasPrice=${this.gasPrice} accessList=${this.accessList?.length} (size)`
     return errorStr
   }