tx: hardhat E2E error msg fix

ethereumjs · Oct 24, 2021 · 130b59b · 130b59b · github-actions · Oct 24, 2021
1 parent e1ec6a0
commit 130b59b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/client/test/rpc/eth/sendRawTransaction.spec.ts b/packages/client/test/rpc/eth/sendRawTransaction.spec.ts
@@ -55,7 +55,7 @@ tape(`${method}: call with invalid tx (wrong chain ID)`, async (t) => {
   const expectRes = checkError(
     t,
     PARSE_ERROR,
-    'serialized tx data could not be parsed (The chain ID does not match the chain ID of Common)'
+    'serialized tx data could not be parsed'
   )
   await baseRequest(t, server, req, 200, expectRes)
 })

diff --git a/packages/tx/src/eip2930Transaction.ts b/packages/tx/src/eip2930Transaction.ts
@@ -403,7 +403,8 @@ export default class AccessListEIP2930Transaction extends BaseTransaction<Access
    */
   public errorStr() {
     let errorStr = this._getSharedErrorPostfix()
-    errorStr += ` gasPrice=${this.gasPrice} accessList=${this.accessList.length} (size)`
+    // Keep ? for this.accessList since this otherwise causes Hardhat E2E tests to fail
+    errorStr += ` gasPrice=${this.gasPrice} accessList=${this.accessList?.length} (size)`
     return errorStr
   }
Benchmark suite	Current: `130b59b`	Previous: `125e210`	Ratio
`Block 9422909`	`11732` ops/sec (`±14.29%`)	`24466` ops/sec (`±1.97%`)	`2.09`
`Block 9422914`	`6913` ops/sec (`±20.43%`)	`17393` ops/sec (`±15.60%`)	`2.52`