Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Use test-fixture fork-selection helpers from py-evm when they become available #621

Closed
veox opened this issue May 17, 2019 · 0 comments
Closed

Comments

@veox
Copy link
Contributor

veox commented May 17, 2019

  • Trinity version: should apply to master still if this issue not outdated
  • OS: IRRELEVANT
  • Python version (output of python --version): IRRELEVANT
  • Environment (output of pip freeze): IRRELEVANT

What is wrong?

(Fallout from PR #608.)

Parts of the test configuration are copy-paste from py-evm, after the py-evm/trinity repo split:

  • the tests that xfail in the pinned version of py-evm will also xfail in trinity, but ATM they can't be imported, so the list is copy-pasted manually;
  • similar for "human comfort" pytest flag --fork;
  • possibly other stuff?..

In an interim commit of PR #608, these were marked with TODOs:

Also tracked in py-evm as issue ethereum/py-evm#1781.

How can it be fixed

🖖

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants