Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts of the test suite could be exposed for downstream use #1781

Open
veox opened this issue May 17, 2019 · 0 comments
Open

Parts of the test suite could be exposed for downstream use #1781

veox opened this issue May 17, 2019 · 0 comments

Comments

@veox
Copy link
Contributor

veox commented May 17, 2019

  • py-evm Version: v0.2.0-alpha.42-112-g5c080532 (current master, commit 5c08053)
  • OS: IRRELEVANT
  • Python Version (python --version): IRRELEVANT
  • Environment (output of pip freeze): IRRELEVANT

What is wrong?

Some utilities, such as the infamous INCORRECT_UPSTREAM_TESTS, but also helpers to select fixture by VM rules (a.k.a. fork), have been copy-pasted between py-evm and trinity since the repo split.

In ethereum/trinity#608, these were marked with TODOs:

How can it be fixed

Move them to somewhere in eth.tools.fixtures?.. Don't know, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant