Add internal ip cli flag #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
testharness
branch
from
a56db9c to
430cc2e
Compare
njgheorghita
force-pushed
the
testharness
branch
from
430cc2e to
cb4512c
Compare
lithp
added a commit
to lithp/trin
that referenced
this pull request
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--internal-ipcli flag to skip requesting external ip address from stun server. This allows the testharness to communicate properly with a locally running target node.I also spent some time trying to clean up the testing structure in the test harness, by catching the panics instead of actually panicking. But, the async nature of the tests made it sufficiently tricky that I'm dropping it for now. https://stackoverflow.com/questions/63159442/how-do-i-use-paniccatch-unwind-with-asynchronous-code
Fixes #147