Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - remove deadlock when pinging bootnodes #142

Merged
merged 1 commit into from
Oct 22, 2021
Merged

bugfix - remove deadlock when pinging bootnodes #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions trin-state/src/network.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ impl StateNetwork {
// Trigger bonding with bootnodes, at both the base layer and portal overlay.
// The overlay ping via talkreq will trigger a session at the base layer, then
// a session on the (overlay) portal network.
let guard = self.overlay.discovery.read_with_warn().await;
for enr in guard.discv5.table_entries_enr() {
let table_entries = {
// use a nested scope so that the guard is quickly dropped
let guard = self.overlay.discovery.read_with_warn().await;
guard.discv5.table_entries_enr()
};
for enr in table_entries {
debug!("Attempting bond with bootnode {}", enr);
let ping_result = self
.overlay
Expand Down