Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Docs translation #5918

Closed
ChrisChinchilla opened this issue Feb 4, 2019 · 22 comments · Fixed by #7097
Closed

Japanese Docs translation #5918

ChrisChinchilla opened this issue Feb 4, 2019 · 22 comments · Fixed by #7097

Comments

@ChrisChinchilla
Copy link
Contributor

ChrisChinchilla commented Feb 4, 2019

This issue is to track the progress of the Japanese translation of the Solidity documentation.

It includes the GitHub usernames of all involved, and links to any issues or pull requests related to the French translation.

All translation efforts in progress from this date are pinned to commit
bb46e91

Contributors

Based on comments in pull requests and issues, and other conversations. If you also want to be involved, please comment below.

@akira-19, @noctrlz, @taizo-kato

Fork

https://github.com/akira-19/solidity

@akira-19
Copy link

akira-19 commented Feb 8, 2019

@ChrisChinchilla Thank you. I just started translating. I'm also going to ask the Japanese community to help this project to make the translation better.

@ChrisChinchilla
Copy link
Contributor Author

@akira-19 Great! So I can help you more and connect you to other Solidity translators, can you email me your email address? Or you can also ping me on https://gitter.im/ethereum/documentation

@akira-19
Copy link

@ChrisChinchilla Hi, I found a couple of people who are going to help the translation. So can you add @noctrlz and @taizo-kato as contributors? And I think they might want to join gitter documentation room.

@ChrisChinchilla
Copy link
Contributor Author

@akira-19 Excellent! I'll add them here, but for creating the translation, you create a fork of this repo, so you can add whoever you like to that. When you have that fork, let me know 👍.

@akira-19
Copy link

@ChrisChinchilla Thank you. The fork is here. https://github.com/akira-19/solidity

@shunMB
Copy link

shunMB commented Apr 16, 2019

@ChrisChinchilla and @akira-19 Hi, can I help this translation? If possible, let me know.

@ChrisChinchilla
Copy link
Contributor Author

@shunMB From my perspective yes, but it's up to @akira-19 mostly :)

@shunMB
Copy link

shunMB commented Apr 18, 2019

@ChrisChinchilla Thank you! @akira-19 I'm waiting for your reply ;)

@akira-19
Copy link

@shunMB
Copy link

shunMB commented Apr 20, 2019

@akira-19 Sure! I just joined the workspace. Thanks!

@ChrisChinchilla
Copy link
Contributor Author

Amazing! 👏

You can also join us in the Ethereum documentation Gitter channel if you want to ;)

https://gitter.im/ethereum/documentation

@ashWhiteHat
Copy link

ashWhiteHat commented Apr 23, 2019 via email

@akira-19
Copy link

@ChrisChinchilla We completed the translation. Can I create pull request to develop branch? We made a directory "docs_jp" on the same level as "docs". Would it be ok with that?

@chriseth
Copy link
Contributor

@axira-19 that's wonderful! How up-to-date is the translation? My main concerns about not merging right away are about versions: The version number in the japanese translation should reflect the actual state of the translation and not of the develop branch. Because of that, you would at least need to modify the part of conf.py that auto-discovers the version and maybe we should find a more sustainable solution to that problem.

@akira-19
Copy link

@ChrisChinchilla We translated based on version 0.5.4. which I forked. During the translation, we didn't merge the "official" documentation. So literally, the Japanese translation is version 0.5.4.

It's hard to catch up with the latest version because the update is pretty fast.
This is the very first Japanese translation and I think we made some mistakes (we tried not to make them though), so we might still need some modifications.

In my opinion, we can publish this and we will modify some mistakes after a while (I think users will point out some mistakes). Then, when version 0.6.0 is published, I can translate breaking changes if I'm available.

What do you say?

@chriseth
Copy link
Contributor

@akira-19 that sounds good! Maybe the best approach forward now is to link to the japanese version from the main page of the solidity docs. Once it is up to date, we can include it inside the repository.

@akira-19
Copy link

@ChrisChinchilla You mean I publish them and you add the link, and you add them into the repository when we finish the modifications?

@chriseth
Copy link
Contributor

Yes!

@akira-19
Copy link

@ChrisChinchilla I got it. I'll let you know when I publish them. Thanks.

@akira-19
Copy link

@ChrisChinchilla I published the translation. Please add the link into the original documentation. Thanks!
https://solidity-jp.readthedocs.io/

@ChrisChinchilla
Copy link
Contributor Author

Sorry @akira-19 I was on holiday, will get this done now, and thank you again for your work, most appreciated!

@akira-19
Copy link

@ChrisChinchilla No worries! I appreciate your quick action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants