Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recorder Enhancement #89

Closed
ryestew opened this issue Feb 25, 2020 · 4 comments
Closed

Recorder Enhancement #89

ryestew opened this issue Feb 25, 2020 · 4 comments
Assignees
@ryestew @yann300
Labels
documentation Improvements or additions to documentation

Comments

@ryestew
Copy link
Collaborator

ryestew commented Feb 25, 2020

The recorder records exactly the transaction done, including the original bytecode which for our usecase it wasn’t what we expected.
* we did a contract with 1 method ‘createProject’ and recorded it
* we then added a second method ‘fundProject’
* we replayed the recording, hoping this would save the trouble of having to redeploy and call createProject again
However it simply reuses/redoes the previous contract deployment that has old bytecode without the new method.
@yann300
Copy link
Contributor

yann300 commented Feb 25, 2020

not really sure I understand the issue here,
if you add a second method fundProject without redeploying the contract then it is not recorded, but that is expected

@LianaHus
Copy link
Collaborator

LianaHus commented Jul 23, 2020 •
edited
Loading

should we keep this, guys? @yann300 @ryestew

@LianaHus LianaHus transferred this issue from ethereum/remix-ide Jul 27, 2020
@LianaHus LianaHus added the documentation Improvements or additions to documentation label Jul 27, 2020
@yann300
Copy link
Contributor

yann300 commented Jul 27, 2020

However it simply reuses/redoes the previous contract deployment that has old bytecode without the new method.

If you didn't recompile, you 'll not get the new method.
what would you propose to do ? @ryestew

ioedeveloper pushed a commit that referenced this issue Sep 29, 2020
@yann300
Merge pull request #89 from ethereum/yann300-patch-8
fea3c68 
typo: rename shareFolder => currentSharedFolder
@ryestew
Copy link
Collaborator Author

ryestew commented Feb 9, 2021

figure out if we need to keep this open

@yann300 yann300 assigned yann300 and ryestew and unassigned yann300 Feb 9, 2021
@ryestew ryestew closed this as completed Jun 16, 2021
yann300 pushed a commit that referenced this issue Jun 1, 2022
@austintgriffith
Merge pull request #89 from ironsoul0/master
a2c82d4 
Payable constructor
bunsenstraat added a commit that referenced this issue Oct 20, 2023
@bunsenstraat
# This is a combination of 92 commits.
13091c2 
# This is the 1st commit message:

uml

# This is the commit message #2:

setvalue fix

# This is the commit message #3:

fix unit test

# This is the commit message #4:

special functions

# This is the commit message #5:

fix value

# This is the commit message #6:

lint

# This is the commit message #7:

statuc

# This is the commit message #8:

api  test

# This is the commit message #9:

port

# This is the commit message #10:

etherscan

# This is the commit message #11:

rm fc

# This is the commit message #12:

tooltip

# This is the commit message #13:

lock

# This is the commit message #14:

screenshots

# This is the commit message #15:

pause test

# This is the commit message #16:

getbrowser

# This is the commit message #17:

logs

# This is the commit message #18:

log env

# This is the commit message #19:

logs

# This is the commit message #20:

test

# This is the commit message #21:

nx url

# This is the commit message #22:

127.0.0.1

# This is the commit message #23:

rm log

# This is the commit message #24:

etherscan

# This is the commit message #25:

.frameParent()

# This is the commit message #26:

retry

# This is the commit message #27:

set flaky

# This is the commit message #28:

flaky

# This is the commit message #29:

logs

# This is the commit message #30:

launch

# This is the commit message #31:

more logs

# This is the commit message #32:

etherscan

# This is the commit message #33:

rm flaky

# This is the commit message #34:

hardhat

# This is the commit message #35:

hardhat

# This is the commit message #36:

hardhat

# This is the commit message #37:

hardhat

# This is the commit message #38:

term

# This is the commit message #39:

screeenshots

# This is the commit message #40:

pause

# This is the commit message #41:

look for gas

# This is the commit message #42:

fix test

# This is the commit message #43:

load compiler

# This is the commit message #44:

force compile

# This is the commit message #45:

logs

# This is the commit message #46:

imeout

# This is the commit message #47:

add pause

# This is the commit message #48:

change contract

# This is the commit message #49:

pause

# This is the commit message #50:

rm extra compile

# This is the commit message #51:

20

# This is the commit message #52:

compile again

# This is the commit message #53:

logs

# This is the commit message #54:

revert

# This is the commit message #55:

rm screens

# This is the commit message #56:

rm logs

# This is the commit message #57:

flaky off

# This is the commit message #58:

resize

# This is the commit message #59:

zoom test

# This is the commit message #60:

flaky

# This is the commit message #61:

test

# This is the commit message #62:

nx_npm

# This is the commit message #63:

flaky

# This is the commit message #64:

log more

# This is the commit message #65:

group it

# This is the commit message #66:

storage

# This is the commit message #67:

some logs

# This is the commit message #68:

look at solidity

# This is the commit message #69:

autocompile

# This is the commit message #70:

test the tooltips off

# This is the commit message #71:

click compile

# This is the commit message #72:

logs

# This is the commit message #73:

show the logs

# This is the commit message #74:

await

# This is the commit message #75:

string the errors

# This is the commit message #76:

log all

# This is the commit message #77:

more log

# This is the commit message #78:

more logs

# This is the commit message #79:

more logs

# This is the commit message #80:

log error

# This is the commit message #81:

log more

# This is the commit message #82:

log more

# This is the commit message #83:

fix timestamp

# This is the commit message #84:

logging

# This is the commit message #85:

dont set null

# This is the commit message #86:

smaller than

# This is the commit message #87:

logs

# This is the commit message #88:

hover test

# This is the commit message #89:

flaky terminal

# This is the commit message #90:

terminal

# This is the commit message #91:

merge group

# This is the commit message #92:

config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryestew ryestew

@yann300 yann300

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryestew @yann300 @LianaHus