Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontier/natspec #668

Merged
merged 22 commits into from
Apr 20, 2015
Merged

Frontier/natspec #668

merged 22 commits into from
Apr 20, 2015
+5,095 −72

Conversation

zsfelfoldi
Copy link
Contributor

NatSpec, end-to-end test, cli option --natspec

@zelig zelig mentioned this pull request Apr 8, 2015
Closed
4 tasks
@obscuren
Copy link
Contributor

obscuren commented Apr 8, 2015

Please rebase

@zelig zelig added the feature label Apr 8, 2015
@zelig zelig added this to the Frontier milestone Apr 8, 2015
@zelig zelig self-assigned this Apr 8, 2015
@obscuren
Copy link
Contributor

Please update the following:

  • Change back the genesis block
  • Rebase again
  • Pick an address that will be used for the NatSpec

@obscuren obscuren removed this from the Frontier milestone Apr 13, 2015
obscuren
obscuren reviewed Apr 16, 2015
View reviewed changes
xeth/xeth.go
@@ -608,6 +608,12 @@ func (self *XEth) Call(fromStr, toStr, valueStr, gasStr, gasPriceStr, dataStr st
return common.ToHex(res), err
}

func (self *XEth) ConfirmTransaction(tx string) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is transactions a string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because natspec.js needs the whole JSON-encoded RPC request, so it was easier to pass it than to re-encode.

@fjl
Copy link
Contributor

fjl commented Apr 17, 2015

It looks like the tests for common/natspec are still hanging on Travis.

zelig and others added 18 commits April 19, 2015 20:57
@zelig
new natspec
d0b3536 
- constructor takes abidoc, userdoc
- json parsing of userdoc
- method found by abi data
- notice found from method
@zelig
natspec integrated to console frontend confirmTransaction
4567638
@zelig
add common/resolver skeleton
97a6028
@zsfelfoldi @zelig
NatSpec, URL register storage retrieval
3136bae 
fixed 2/3 tests
@zelig
add docserver using net/http Transport/Roundtrip
5b0ea10
@zelig
reorg:
3a54042 
- statereg methods move to natspec/resolver/docserver
- fix failing test on invalid js input
@zelig
resolver tests
ac0e5e8 
- add resolver tests and fix resolver to pass
- statereg constructor fixed
- comments added to natspec plus docserver integration for natspec userdoc fetching
@zsfelfoldi @zelig
NatSpec contracts in genesis block, end to end test (unfinished)
e2d333d
@zsfelfoldi @zelig
s
94489b2
@zsfelfoldi @zelig
NatSpec passing end to end test
b635cad
@zsfelfoldi @zelig
natspec test bugfix
8e6a068
@zsfelfoldi @zelig
default fallback NatSpec messages
b46e152
@zsfelfoldi @zelig
NatSpec cli option, resolver tests passing
c4b7d4d
@zsfelfoldi @zelig
utils linked to natspec notice eval, test notice now using utils.toHex()
f255336
@zsfelfoldi @zelig
NatSpec contracts are now not in the genesis block but added by the test
dba2367
@zsfelfoldi @zelig
test account is no longer permanently in genesis block, only put ther…
d8fb834 
…e when testing
@zsfelfoldi @zelig
fixed incomplete merge
bb793c8
@zsfelfoldi @zelig
added missing source file
b6fe9e0
zsfelfoldi and others added 4 commits April 19, 2015 20:57
@zsfelfoldi @zelig
URLhint support for URLs longer than 32 bytes
929428d
@zsfelfoldi @zelig
fixed resolver test
e9874cb
@zelig
fix end to end test import cycle
71c974f
@zelig
contract addresses include hex prefix
093a910 
- simplify resolver and tests
- added missing test for KeyToUrl
- fix notice error message and its test with !%x(MISSING)
- natspec test: insertTx modified - does not prepend 0x to contract address
- disable networking in e2e test
@zelig zelig force-pushed the frontier/natspec branch from 6c46e65 to 093a910 Compare April 19, 2015 20:15
@zsfelfoldi
Copy link
Contributor Author

Sure, in its final form URL reg should be one single call with a variable length parameter. Tried that with no success, even checked the EVM byte code which made no sense to me. Maybe the compiler can't handle this yet?

@obscuren obscuren merged commit 093a910 into ethereum:develop Apr 20, 2015
@zelig zelig mentioned this pull request Apr 20, 2015
Closed
14 tasks
@zelig zelig deleted the frontier/natspec branch December 8, 2015 20:51
jpeletier added a commit to epiclabs-io/go-ethereum that referenced this pull request Jul 21, 2018
@jpeletier
swarm/storage/mru: client-side mru signatures
46e2a7d 
Rebase to PR ethereum#668 and fix all conflicts
jpeletier added a commit to epiclabs-io/go-ethereum that referenced this pull request Jul 23, 2018
@jpeletier @nonsense
swarm/storage/mru: Client-side MRU signatures (ethereum#784)
427316a 
* swarm/storage/mru: Add embedded publickey and remove ENS dep

This commit breaks swarm, swarm/api...
but tests in swarm/storage/mru pass

* swarm: Refactor swarm, swarm/api to mru changes, make tests pass

* swarm/storage/mru: Remove self from recv, remove test ens vldtr

* swarm/storage/mru: Remove redundant test, expose ResourceHash mthd

* swarm/storage/mru: Make HeaderGetter mandatory + godoc fixes

* swarm/storage: Remove validator prefix for metadata chunk

* swarm/storage/mru: Use Address instead of PublicKey

* swarm/storage/mru: Change index from name to metadata chunk addr

* swarm/storage/mru: Refactor swarm/api/... to MRU index changes

* swarm/storage/mru: Refactor cleanup

* swarm/storage/mru: Rebase cleanup

* swarm: Use constructor for GenericSigner MRU in swarm.go

* swarm/storage: Change to BMTHash for MRU hashing

* swarm/storage: Reduce loglevel on chunk validator logs

* swarm/storage/mru: Delint

* swarm: MRU Rebase cleanup

* swarm/storage/mru: client-side mru signatures

Rebase to PR ethereum#668 and fix all conflicts

* swarm/storage/mru:  refactor and documentation

* swarm/resource/mru: error-checking  tests for parseUpdate/newUpdateChunk

* swarm/storage/mru: Added resourcemetadata tests

* swarm/storage/mru: Added tests  for UpdateRequest

* swarm/storage/mru: more test coverage for UpdateRequest and comments

* swarm/storage/mru: Avoid fake chunks in parseUpdate()

* swarm/storage/mru: Documented resource.go extensively

moved some functions where they make most sense

* swarm/storage/mru: increase test coverage for UpdateRequest and

variable name changes throughout to increase consistency

* swarm/storage/mru: moved default timestamp to NewCreateRequest-

* swarm/storage/mru: lookup refactor

* swarm/storage/mru: added comments and renamed raw flag to rawmru

* swarm/storage/mru: fix receiver typo

* swarm/storage/mru: refactored update chunk new/create

* swarm/storage/mru:  refactored signature digest to avoid malleability

* swarm/storage/mru: optimize update data serialization

* swarm/storage/mru: refactor and cleanup

* swarm/storage/mru: add timestamp struct and serialization

* swarm/storage/mru: fix lint error and mark some old code for deletion

* swarm/storage/mru: remove unnecessary variable

* swarm/storage/mru: Added more comments throughout

* swarm/storage/mru: Refactored metadata chunk layout + extensive error...

* swarm/storage/mru: refactor cli parser
Changed resource info output to JSON

* swarm/storage/mru: refactor serialization for extensibility

refactored error messages to NewErrorf

* swarm/storage/mru: Moved Signature to resource_sign.
Check Sign errors in server tests

* swarm/storage/mru: Remove isSafeName() checks

* swarm/storage/mru: scrubbed off all references to "block" for time

* swarm/storage/mru: removed superfluous isSynced() call.

* swarm/storage/mru: remove isMultihash() and ToSafeName functions

* swarm/storage/mru: various fixes and comments

* swarm/storage/mru: decoupled cli for independent create/update
* Made resource name optional
* Removed unused LookupPrevious

* swarm/storage/mru: Decoupled resource create / update & refactor

* swarm/storage/mru: Fixed some comments as per issues raised in PR ethereum#743

* swarm/storage/mru: Cosmetic changes as per ethereum#743 comments

* swarm/storage/mru: refct request encoder/decoder > marshal/unmarshal

* swarm/storage/mru: Cosmetic changes as per review in ethereum#748

* swarm/storage/mru: removed timestamp proof placeholder

* swarm/storage/mru: cosmetic/doc/fixes changes as per comments in ethereum#704

* swarm/storage/mru: removed unnecessary check in Handler.update

* swarm/storage/mru: Implemented Marshaler/Unmarshaler iface in Request

* swarm/storage/mru: Fixed linter error

* swarm/storage/mru: removed redundant address in signature digest

* swarm/storage/mru: fixed bug: LookupLatestVersionInPeriod not working

* swarm/storage/mru: Unfold Request creation API for create or update+create
set common time source for mru package

* swarm/api/http: fix HandleGetResource error variable shadowed
when requesting a resource that does not exist

* swarm/storage/mru: Add simple check to detect duplicate updates

* swarm/storage/mru: moved Multihash() to the right place.

* cmd/swarm: remove unneeded clientaccountmanager.go

* swarm/storage/mru: Changed some comments as per reviews in ethereum#784

* swarm/storage/mru: Made SignedResourceUpdate.GetDigest() public

* swarm/storage/mru: cosmetic changes as per comments in ethereum#784

* cmd/swarm: Inverted --multihash flag default

* swarm/storage/mru: removed Verify from SignedResourceUpdate.fromChunk

* swarm/storage/mru: Moved validation code out of serializer
Cosmetic / comment changes

* swarm/storage/mru: Added unit tests for UpdateLookup

* swarm/storage/mru: Increased coverage of metadata serialization

* swarm/storage/mru: Increased test coverage of updateHeader serializers

* swarm/storage/mru: Add resourceUpdate serializer test
firmianavan pushed a commit to firmianavan/go-ethereum that referenced this pull request Aug 28, 2018
@jpeletier @firmianavan
swarm/storage/mru: Client-side MRU signatures (ethereum#784)
7528758 
* swarm/storage/mru: Add embedded publickey and remove ENS dep

This commit breaks swarm, swarm/api...
but tests in swarm/storage/mru pass

* swarm: Refactor swarm, swarm/api to mru changes, make tests pass

* swarm/storage/mru: Remove self from recv, remove test ens vldtr

* swarm/storage/mru: Remove redundant test, expose ResourceHash mthd

* swarm/storage/mru: Make HeaderGetter mandatory + godoc fixes

* swarm/storage: Remove validator prefix for metadata chunk

* swarm/storage/mru: Use Address instead of PublicKey

* swarm/storage/mru: Change index from name to metadata chunk addr

* swarm/storage/mru: Refactor swarm/api/... to MRU index changes

* swarm/storage/mru: Refactor cleanup

* swarm/storage/mru: Rebase cleanup

* swarm: Use constructor for GenericSigner MRU in swarm.go

* swarm/storage: Change to BMTHash for MRU hashing

* swarm/storage: Reduce loglevel on chunk validator logs

* swarm/storage/mru: Delint

* swarm: MRU Rebase cleanup

* swarm/storage/mru: client-side mru signatures

Rebase to PR ethereum#668 and fix all conflicts

* swarm/storage/mru:  refactor and documentation

* swarm/resource/mru: error-checking  tests for parseUpdate/newUpdateChunk

* swarm/storage/mru: Added resourcemetadata tests

* swarm/storage/mru: Added tests  for UpdateRequest

* swarm/storage/mru: more test coverage for UpdateRequest and comments

* swarm/storage/mru: Avoid fake chunks in parseUpdate()

* swarm/storage/mru: Documented resource.go extensively

moved some functions where they make most sense

* swarm/storage/mru: increase test coverage for UpdateRequest and

variable name changes throughout to increase consistency

* swarm/storage/mru: moved default timestamp to NewCreateRequest-

* swarm/storage/mru: lookup refactor

* swarm/storage/mru: added comments and renamed raw flag to rawmru

* swarm/storage/mru: fix receiver typo

* swarm/storage/mru: refactored update chunk new/create

* swarm/storage/mru:  refactored signature digest to avoid malleability

* swarm/storage/mru: optimize update data serialization

* swarm/storage/mru: refactor and cleanup

* swarm/storage/mru: add timestamp struct and serialization

* swarm/storage/mru: fix lint error and mark some old code for deletion

* swarm/storage/mru: remove unnecessary variable

* swarm/storage/mru: Added more comments throughout

* swarm/storage/mru: Refactored metadata chunk layout + extensive error...

* swarm/storage/mru: refactor cli parser
Changed resource info output to JSON

* swarm/storage/mru: refactor serialization for extensibility

refactored error messages to NewErrorf

* swarm/storage/mru: Moved Signature to resource_sign.
Check Sign errors in server tests

* swarm/storage/mru: Remove isSafeName() checks

* swarm/storage/mru: scrubbed off all references to "block" for time

* swarm/storage/mru: removed superfluous isSynced() call.

* swarm/storage/mru: remove isMultihash() and ToSafeName functions

* swarm/storage/mru: various fixes and comments

* swarm/storage/mru: decoupled cli for independent create/update
* Made resource name optional
* Removed unused LookupPrevious

* swarm/storage/mru: Decoupled resource create / update & refactor

* swarm/storage/mru: Fixed some comments as per issues raised in PR ethereum#743

* swarm/storage/mru: Cosmetic changes as per ethereum#743 comments

* swarm/storage/mru: refct request encoder/decoder > marshal/unmarshal

* swarm/storage/mru: Cosmetic changes as per review in ethereum#748

* swarm/storage/mru: removed timestamp proof placeholder

* swarm/storage/mru: cosmetic/doc/fixes changes as per comments in ethereum#704

* swarm/storage/mru: removed unnecessary check in Handler.update

* swarm/storage/mru: Implemented Marshaler/Unmarshaler iface in Request

* swarm/storage/mru: Fixed linter error

* swarm/storage/mru: removed redundant address in signature digest

* swarm/storage/mru: fixed bug: LookupLatestVersionInPeriod not working

* swarm/storage/mru: Unfold Request creation API for create or update+create
set common time source for mru package

* swarm/api/http: fix HandleGetResource error variable shadowed
when requesting a resource that does not exist

* swarm/storage/mru: Add simple check to detect duplicate updates

* swarm/storage/mru: moved Multihash() to the right place.

* cmd/swarm: remove unneeded clientaccountmanager.go

* swarm/storage/mru: Changed some comments as per reviews in ethereum#784

* swarm/storage/mru: Made SignedResourceUpdate.GetDigest() public

* swarm/storage/mru: cosmetic changes as per comments in ethereum#784

* cmd/swarm: Inverted --multihash flag default

* swarm/storage/mru: removed Verify from SignedResourceUpdate.fromChunk

* swarm/storage/mru: Moved validation code out of serializer
Cosmetic / comment changes

* swarm/storage/mru: Added unit tests for UpdateLookup

* swarm/storage/mru: Increased coverage of metadata serialization

* swarm/storage/mru: Increased test coverage of updateHeader serializers

* swarm/storage/mru: Add resourceUpdate serializer test
ngtuna added a commit to ngtuna/tomochain that referenced this pull request Sep 5, 2019
@ngtuna
Merge pull request ethereum#668 from ngtuna/reduce-log
1dec1c6 
reduce log debug
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this pull request Jan 20, 2022
Print public key in ECDSA account proof-of-possession (ethereum#668)
a8f2ee1
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Jan 31, 2022
@unclezoro
[R4R] implement State Verification && Snapshot Commit pipeline (ether…
eb7e309 
…eum#668)

* pipeline commit trie

add metrics

reopen trie

* add unit testcase

* resolve keefe's comment

* resolve igor's comments

* update prefetch

remove prefetcher

* no need to return error for precacheTransaction

* fix lint issue

* add some comments

* remove useless code

* add default option is false

* fix diffsync nil point

* fix panic on  GetProofByHash

Co-authored-by: zjubfd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zelig zelig

Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zsfelfoldi @obscuren @fjl @zelig @adamschmideg