build: remove hash metadata from cocoapod version #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we used
<version>-<hash>as the version string for iOS CocoaPods packages. This turned out to be considered a pre-release by cocoapods, which follows thesemverspecification. A previous commit changed our iOS version strings to<version>+<hash>which represents build metadata according to thesemverspec used by CocoaPods. Unfortunately it again turned out that CocoaPods doesn't like it (CocoaPods/CocoaPods#6224), so for now at least this PR just drops all build metainfos and keeps to the plain version number only. Since we ship stable and develop versions as separate packages, there should be no issue with this anyway.