internal/ethapi: fix prev hashes in eth_simulate #31122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
reviewed
Feb 3, 2025
| @@ -73,6 +73,19 @@ func (r *simCallResult) MarshalJSON() ([]byte, error) { | |||
| return json.Marshal((*callResultAlias)(r)) | |||
| } | |||
|
|
|||
| // simBlockResult is the result of a simulated block. | |||
| type simBlockResult struct { | |||
| sim *simulator | |||
There was a problem hiding this comment.
Feels weird to me to include a pointer to the simulator when you really only need the config + fullTx. But even still, I don't see why you need to return these at all. execute is a method on sim so the caller will always have sim around to do the RPCMarshalBlock correctly.
| // simBlockResult is the result of a simulated block. | ||
| type simBlockResult struct { | ||
| sim *simulator | ||
| Block *types.Block |
There was a problem hiding this comment.
I'm wondering if storing the block here will increase the memory usage of eth simulate over a longer period of blocks significantly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shout-out to @Gabriel-Trintinalia for discovering this issue. The gist of it as follows:
When processing a block, we should provide the parent block as well as the last 256 block hashes. Some of these parents data (specifically the hash) was incorrect because even though during the processing of the parent block we have updated the header, that header was not updating the TransactionsRoot and ReceiptsRoot fields (types.NewBlock makes a new copy of the header and changes it only on that instance).