fix nil pointer when block does not exist #31116
Conversation
ysk49
requested review from
fjl,
s1na,
lightclient,
holiman and
rjl493456442
as code owners
| @@ -114,9 +114,6 @@ func (api *API) blockByNumber(ctx context.Context, number rpc.BlockNumber) (*typ | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if block == nil { | |||
| return nil, fmt.Errorf("block #%d not found", number) | |||
| } | |||
There was a problem hiding this comment.
block, err := api.backend.BlockByNumber(ctx, number), returning err if block is nil.
Therefore, this handling is unnecessary and has been removed.
https://github.com/ethereum/go-ethereum/pull/31116/files#diff-bd288cd51c1874c7e65ce0d35047c0a98366479c8924606c9efc577f6a98f75cR113
| return "", fmt.Errorf("block #%d not found", number) | ||
| block, err := api.b.BlockByNumber(ctx, rpc.BlockNumber(number)) | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
api.b.BlockByNumber(ctx, rpc.BlockNumber(number)) returns an error if block is nil,
so if block == nil {...} handling becomes unnecessary.
|
As expressed in the last PR, I disagree with this change as of now. The spec requires us to return nil for not found objects: https://ethereum.github.io/execution-apis/api-documentation/ So if there is a panic, please check the |
|
Seems like @rjl493456442 @s1na and I have different opinions on how to do this change, but we all agree that it should be fixed. We should discuss on triage |
This PR fixes "nil pointer error occurs when block is nil".
The following
GetBlockByNumberfunction is used in several places, but only infunc (b *EthAPIBackend) BlockByNumber(ctx context.Context, number rpc.BlockNumber) (*types.Block, error)ateth/api_backend.godid not implement error handling when block is nil.https://github.com/ethereum/go-ethereum/blob/master/eth/api_backend.go#L146
So I think we also should fix the
b.BlockByNumber, by returning the error if the required block is not existent.quote: #31104 (comment)