consensus/misc/eip4844: use head's target blobs, not parent #31101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkhadem4
approved these changes
Feb 1, 2025
|
The diff to #31002 looks good! |
fjl
requested review from
fjl,
holiman,
karalabe,
gballet,
rjl493456442,
zsfelfoldi,
MariusVanDerWijden,
s1na and
jwasinger
as code owners
s1na
reviewed
Feb 4, 2025
s1na
reviewed
Feb 4, 2025
|
Fixed up based on review comments, thx. |
gballet
reviewed
Feb 4, 2025
gballet
approved these changes
Feb 4, 2025
tokeyg
pushed a commit
to tokeyg/go-ethereum
that referenced
this pull request
Feb 6, 2025
…#31101) A clarification was made to EIP-7691 stating that at the fork boundary it is required to use the target blob count associated with the head block, rather than the parent as implemented here. See for more: ethereum/EIPs#9249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on #31002.--
A clarification was made to EIP-7691 stating that at the fork boundary it is required to use the target blob count associated with the head block, rather than the parent as implemented here.
See for more: ethereum/EIPs#9249