core/txpool, eth/catalyst: clear transaction pool in Rollback #30534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
requested review from
gballet,
lightclient,
karalabe,
holiman and
rjl493456442
as code owners
jwasinger
changed the title
karalabe
reviewed
Oct 1, 2024
core/txpool/subpool.go
Outdated
| @@ -162,4 +162,7 @@ type SubPool interface { | |||
| // Status returns the known status (unknown/pending/queued) of a transaction | |||
| // identified by their hashes. | |||
| Status(hash common.Hash) TxStatus | |||
|
|
|||
| // DropTransactions removes all tracked transactions from the pool | |||
| DropTransactions() | |||
holiman
reviewed
Oct 1, 2024
karalabe
reviewed
Oct 1, 2024
| p.lock.Lock() | ||
| defer p.lock.Unlock() | ||
|
|
||
| // manually iterating and deleting every entry is super sub-optimal |
There was a problem hiding this comment.
We should probably iterate and unreserve the addresses here. It's less optimal that recreating the reservations map in the parent pool, but that's very sensitive datarace wise, so it's simpler to iterate for now.
karalabe
reviewed
Oct 1, 2024
core/txpool/legacypool/legacypool.go
Outdated
| p.mu.Lock() | ||
| defer p.mu.Unlock() | ||
|
|
||
| p.all = newLookup() |
There was a problem hiding this comment.
We should probably iterate and unreserve the addresses here. It's less optimal that recreating the reservations map in the parent pool, but that's very sensitive datarace wise, so it's simpler to iterate for now.
…interface. Make simulated beacon rollback use the new method, fix old hack
…it's not done at the TxPool level.
fjl
changed the title
fjl
force-pushed
the
pool-drop-all-txs
branch
from
0bc3138 to
e4e0c45
Compare
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This adds an API method `DropTransactions` to legacy pool, blob pool and txpool interface. This method removes all txs currently tracked in the pools. It modifies the simulated beacon to use the new method in `Rollback` which removes previous hacky implementation that also erroneously reset the gas tip to 1 gwei. --------- Co-authored-by: Felix Lange <[email protected]>
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
…um#30534) This adds an API method `DropTransactions` to legacy pool, blob pool and txpool interface. This method removes all txs currently tracked in the pools. It modifies the simulated beacon to use the new method in `Rollback` which removes previous hacky implementation that also erroneously reset the gas tip to 1 gwei. --------- Co-authored-by: Felix Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API method
DropTransactionsto legacy pool, blob pool and txpool interface. This method removes all txs currently tracked in the pools.It modifies the simulated beacon to use the new method in
Rollbackwhich removes previous hacky implementation that also erroneously reset the gas tip to 1 gwei.