fix(usbwallet): improve ledger support #28863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just re-read the whole convo @holiman - I still will keep this open for anyone that may want to unblock themselves until the long term fix is fully merged. |
|
We have the ticket #28711, I think that should suffice for anyone looking into this issue seeking a short term solution. Since we're going to fix the issue by updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Ledger devices to be found at multiple
usageID. I found newer Ledger devices were failing to be discovered on Mac because they have ausageIDvalue of0instead of originally0xffa0.To keep backward compatibility now both
usageIDvalues are supported.