cmd/geth: make it possible to autopilot removedb #28721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
(base) ➜ project geth removedb --datadir ./sepolia y,n
INFO [12-22|11:39:13.785] Maximum peer count ETH=50 total=50
INFO [12-22|11:39:13.798] Set global gas cap cap=50,000,000
INFO [12-22|11:39:13.798] Initializing the KZG library backend=gokzg
Location(s) of 'state data':
- /Users/mac/project/sepolia/geth/chaindata
- /Users/mac/project/sepolia/geth/chaindata/ancient/state
Remove 'state data'? [y/n] y
INFO [12-22|11:39:13.843] Database successfully deleted kind="state data" paths="[/Users/mac/project/sepolia/geth/chaindata /Users/mac/project/sepolia/geth/chaindata/ancient/state]" elapsed=1.483ms
Location(s) of 'ancient chain':
- /Users/mac/project/sepolia/geth/chaindata/ancient/chain
Remove 'ancient chain'? [y/n] n
INFO [12-22|11:39:13.843] Database deletion skipped kind="ancient chain" paths=[/Users/mac/project/sepolia/geth/chaindata/ancient/chain]
Looks good to me
|
After considering it some more: this PR is not good.
A better solution would be to use explicit cli.v2 flags, like such: where
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When managing geth over docker, sometimes it's desirable to do a partial wipe: delete state but retain freezer data. This can be a bit tricky: the ansible scripts to delete files individually are slow, a faster way to do it is to
This "works" but it's clumsy, and now that we have both block-data and state-data in freezer, it's a bit incomplete, the correct thing to do would be to save only the block-data, not the state-data.
This PR implements an alternative way to achieve the same thing, by making it possible to run
geth removedbnon-interactive, feeding responses via arguments instead.Classic usage, with bad input (no delete, no error-msg):
New usage, bad input via arguments (no delete, no error-msg)::
Good input (yes, no)
Good input yes, yes:
Only one input (prompts for second input):