Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t8ntool: tiny bugfix for difficulty field #28245

Merged
merged 1 commit into from
Oct 4, 2023
Merged

t8ntool: tiny bugfix for difficulty field #28245

merged 1 commit into from
Oct 4, 2023

Conversation

tactical-retreat
Copy link
Contributor

Pretty straightforward bugfix, although tests pass before and after.

lightclient
lightclient approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be correct. Likely wasn't caught anywhere because i.Header.difficulty is rarely nil.

@karalabe karalabe added this to the 1.13.3 milestone Oct 4, 2023
@karalabe karalabe merged commit 052355f into ethereum:master Oct 4, 2023
hyunchel pushed a commit to hyunchel/go-ethereum that referenced this pull request Oct 6, 2023
@tactical-retreat @hyunchel
cmd/evm/internal/t8ntoo: tiny bugfix for difficulty field (ethereum#2…
d1691b6 
…8245)
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
@tactical-retreat @tyler-smith
cmd/evm/internal/t8ntoo: tiny bugfix for difficulty field (ethereum#2…
eac9526 
…8245)
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
@tactical-retreat @tyler-smith
cmd/evm/internal/t8ntoo: tiny bugfix for difficulty field (ethereum#2…
585231e 
…8245)
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@tactical-retreat @devopsbo3
cmd/evm/internal/t8ntoo: tiny bugfix for difficulty field (ethereum#2…
f22ae6a 
…8245)
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "cmd/evm/internal/t8ntoo: tiny bugfix for difficulty field (et…
da34ca6 
…hereum#28245)"

This reverts commit f22ae6a.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "cmd/evm/internal/t8ntoo: tiny bugfix for difficulty field (et…
d3fd16d 
…hereum#28245)"

This reverts commit f22ae6a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tactical-retreat @lightclient @karalabe