core, params, beacon/engine: implement EIP 4788 BeaconRoot #27849

holiman · 2023-08-03T19:35:51Z

EIP 4788 : Beacon block root in the EVM

This is a version-2 of EPI-4788, main difference being that the contract is an actual contract rather than a precompile, as in #27289.

cc @ralexstokes

consensus/misc: add eip4788 consensus/misc: header core/vm: allow for stateful precompiles core/vm: implement 4788 as a stateful precompile core, consensus/misc: update to new 4788 spec core: fix rebase core/vm: add activator core/vm: reduce interface, increase testability, remove opcode params: introduce params.BeaconRootStorageAddress happy lint, happy life core: make sure to only apply beaconroot after cancun! params, consensus: fix review comments

consensus/misc: set beaconroot precompile non-zero nonce (poc)

yperbasis · 2023-08-07T14:20:17Z

core/state_processor.go

+		// we can use the header.BaseFee and set that instead.
+		msg := &Message{
+			From:      params.SystemAddress,
+			GasLimit:  100_000,


I suggest to use gas limit of 30_000_000 to be in line with the Gnosis Chain spec for system transactions.

lightclient · 2023-08-11T21:20:28Z

core/state_processor.go

@@ -66,6 +66,7 @@ func (p *StateProcessor) Process(block *types.Block, statedb *state.StateDB, cfg
 		blockNumber = block.Number()
 		allLogs     []*types.Log
 		gp          = new(GasPool).AddGas(block.GasLimit())
+		beaconRoot  *common.Hash


Is this just a placeholder until we later activate this by checking block.BeaconRoot?

Right, yeah we should remove this and use block.BeaconRoot instead. Looks very odd like that

Ah, yeah that change is probably in the follow-up PR

Hm, #27872 is the follow-up, but it still doesn't fill this placeholder :/

Yeah no worries, I have these changes in the devnet-8 branch. I'm not sure the best way to be tracking this for everyone as it pretty out-of-sync with master.

@lightclient thanks for adding your updates, I have also pushed some changes now -- primarily, hooking it into evm t8n so I could actually test it and see it working in practice.
PTAL

core/types/block.go

core/state_processor.go

…'t panic

core/state_processor.go

lightclient · 2023-08-20T22:13:17Z

cmd/evm/internal/t8ntool/transition.go

@@ -292,6 +292,14 @@ func Transition(ctx *cli.Context) error {
 		prestate.Env.Difficulty = calcDifficulty(chainConfig, env.Number, env.Timestamp,
 			env.ParentTimestamp, env.ParentDifficulty, env.ParentUncleHash)
 	}
+	if chainConfig.IsCancun(big.NewInt(int64(prestate.Env.Number)), prestate.Env.Timestamp) {


big.NewInt(int64(prestate.Env.Number)

seems like this is used a lot, might be nice to assign above ?

Myeah, a couple, but I don't think it's worth it. Might do a bigger refactor later IMO

I mean, some uses refer to big.NewInt(int64(prestate.Env.Number)), some refer to int64(prestate.Env.Number), and some refer to prestate.Env.Number

Did the bigger refactor, ptal!

lightclient · 2023-08-20T22:14:19Z

cmd/evm/internal/t8ntool/transition.go

+			return NewError(ErrorConfig, errors.New("post-cancun env requires parentBeaconBlockRoot to be set"))
+		}
+	} else {
+		env.ParentBeaconBlockRoot = nil // un-set it if it has been set too early


Shouldn't it be an error if beacon root is requested before the fork?

We could but in go-ethereum, due to how the json parser works, we typically ignore extraneous json-fields. I think the engine-api is the sole exception where we explicitly check for, and error on, fields that we do not expect.

For t8n, I'd prefer to keep the older behaviour

cmd/evm/testdata/29/readme.md

consensus/beacon/consensus.go

core/state_processor.go

params/protocol_params.go

…erns

lightclient

LGTM

See ethereum/EIPs#7456 & ethereum/go-ethereum#27849. Also set the gas limit for system calls to 30M (previously 2^64-1), which is in line with the [Gnosis spec](https://github.com/gnosischain/specs/blob/master/execution/withdrawals.md#specification), but should be doubled checked for Gnosis Chain.

…27849) This change implements "EIP 4788 : Beacon block root in the EVM". It implements version-2 of EPI-4788, main difference being that the contract is an actual contract rather than a precompile, as in ethereum#27289.

…thereum#27849)" This reverts commit 2e9477f.

Conflicts: cmd/evm/internal/t8ntool/transition.go Callsite for IsShanghai moved to a different function, moved our modification there. Additions: go-ethereum/cmd/evm/testdata/29/exp.json Added Arbitrum field to expected receipt.

MariusVanDerWijden and others added 5 commits August 4, 2023 17:33

consensus/misc: turn 4788-beaconroot calc tests into json

3d54be4

consensus/misc: set beaconroot precompile non-zero nonce (poc)

core/vm: add beacon root pre-compile address to cancun contracts.

8de1782

consensus/misc, core/vm: make beaconroot contract not be precompile

8c0f8e0

core: implement simple beacon root system call

71ade50

holiman force-pushed the eip-4788-v2 branch from deb6314 to 71ade50 Compare August 4, 2023 15:37

core: move check from state processor to header validation, update types

10b478d

holiman added the cancun label Aug 7, 2023

holiman marked this pull request as ready for review August 7, 2023 11:14

holiman requested review from karalabe and rjl493456442 as code owners August 7, 2023 11:14

holiman changed the title ~~[WIP] Eip 4788 v2~~ implement EIP 4788: BeaconRoot Aug 7, 2023

holiman mentioned this pull request Aug 7, 2023

beacon/engine, eth/catalyst, miner: 4788 CL/EL protocol updates #27872

Merged

yperbasis reviewed Aug 7, 2023

View reviewed changes

lightclient reviewed Aug 11, 2023

View reviewed changes

lightclient reviewed Aug 14, 2023

View reviewed changes

core/types/block.go Outdated Show resolved Hide resolved

core/types: correct beacon root json ident

746adf2

lightclient mentioned this pull request Aug 14, 2023

cancun-devnet-8 tracker #27925

Closed

lightclient reviewed Aug 14, 2023

View reviewed changes

core/state_processor.go Outdated Show resolved Hide resolved

lightclient and others added 3 commits August 14, 2023 10:30

core/state_processor: don't use nil value in call

3dcfd13

core: add beacon roots storage address to access list so sstore doesn…

f1d808f

…'t panic

core/types: go generate

d513b40

holiman added the status:triage label Aug 15, 2023

holiman force-pushed the eip-4788-v2 branch from 352dee2 to 0d64483 Compare August 15, 2023 18:10

holiman commented Aug 17, 2023

View reviewed changes

core/state_processor.go Outdated Show resolved Hide resolved

holiman force-pushed the eip-4788-v2 branch from 0c3a6fa to a02512f Compare August 17, 2023 06:21

cmd/evm: enable eip-4788 in evm t8n

3b794e9

holiman force-pushed the eip-4788-v2 branch from a02512f to 3b794e9 Compare August 17, 2023 06:25

lightclient reviewed Aug 20, 2023

View reviewed changes

holiman commented Aug 21, 2023

View reviewed changes

params/protocol_params.go Outdated Show resolved Hide resolved

holiman added 3 commits August 21, 2023 15:48

core, cmd/evm, params: update beaconroot address, address review conc…

dbc1aac

…erns

cmd/evm: refactor t8n for clarity

2b67330

cmd/evm/internal/t8ntool: minor refactorings

9e578a5

lightclient approved these changes Aug 22, 2023

View reviewed changes

holiman added this to the 1.13.0 milestone Aug 22, 2023

holiman changed the title ~~implement EIP 4788: BeaconRoot~~ core, params, beacon/engine: implement EIP 4788 BeaconRoot Aug 22, 2023

holiman merged commit b8d38e7 into ethereum:master Aug 22, 2023

holiman mentioned this pull request Aug 22, 2023

core: implement EIP-4788 BeaconRoot precompile #27289

Closed

yperbasis mentioned this pull request Aug 23, 2023

EIP-4788 v2 (no precompile) erigontech/erigon#8038

Merged

holiman deleted the eip-4788-v2 branch October 11, 2023 07:27

devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

Revert "core, params, beacon/engine: implement EIP 4788 BeaconRoot (e…

016aaa6

…thereum#27849)" This reverts commit 2e9477f.

devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023

Revert "core, params, beacon/engine: implement EIP 4788 BeaconRoot (e…

96f6fe3

…thereum#27849)" This reverts commit 2e9477f.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core, params, beacon/engine: implement EIP 4788 BeaconRoot #27849

core, params, beacon/engine: implement EIP 4788 BeaconRoot #27849

holiman commented Aug 3, 2023

yperbasis Aug 7, 2023

lightclient Aug 11, 2023

holiman Aug 14, 2023

holiman Aug 14, 2023

holiman Aug 14, 2023

lightclient Aug 14, 2023

holiman Aug 15, 2023

lightclient Aug 20, 2023

holiman Aug 21, 2023

holiman Aug 21, 2023

holiman Aug 21, 2023

lightclient Aug 20, 2023

holiman Aug 21, 2023

lightclient left a comment

core, params, beacon/engine: implement EIP 4788 BeaconRoot #27849

core, params, beacon/engine: implement EIP 4788 BeaconRoot #27849

Conversation

holiman commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lightclient left a comment

Choose a reason for hiding this comment