core, eth/downloader: validate blobtx.To at serialization time #27393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah |
lightclient
approved these changes
May 31, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
ethereum#27393)" This reverts commit 0eb3a6c.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
ethereum#27393)" This reverts commit 0eb3a6c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 4844 spec states that the data format of blob txs allows the
Tofield to benull, but such transactions are rejected as invalid during block processing. This is a weird take (probably an omission to be fixed) since this essentially means that theTofields cannot benull, but rejects the fact later in the processing pipeline.This PR changes the
Tofield from*common.Addresstocommon.Address. This will ensure thatnilwill never enter Geth inside a blob transaction. Interestingly, this PR can be merged even now without a spec change, since both versions of this (reject at parse time vs reject at interpretation time) have the same effect.Still, would be nice to confirm in the spec that nilness should be forbidden altogether.