internal/ethapi: prevent unnecessary resource usage in eth_getProof implementation #27310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
changed the title
| // GetProof returns the Merkle-proof for a given account and optionally some storage keys. | ||
| func (s *BlockChainAPI) GetProof(ctx context.Context, address common.Address, storageKeys []string, blockNrOrHash rpc.BlockNumberOrHash) (*AccountResult, error) { | ||
| var ( | ||
| keys = make([]common.Hash, len(storageKeys)) | ||
| storageProof = make([]StorageResult, len(storageKeys)) |
There was a problem hiding this comment.
Maybe storageProofs?
Co-authored-by: Marius van der Wijden <[email protected]>
|
Thanks for the cleanup 🙏 |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…mplementation (ethereum#27310) Deserialize hex keys early to shortcut on invalid input, and re-use the account storageTrie for each proof for each proof in the account, preventing repeated deep-copying of the trie. Closes ethereum#27308 -------- Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…tProof implementation (ethereum#27310)" This reverts commit 4fb4311.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…tProof implementation (ethereum#27310)" This reverts commit 4fb4311.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27308
storageTriefor each proof for each proof in the account, preventing repeated deep-copying of the trieCode smell:
I duplicated the
proofListtype rather than making it public. Making it public seemed like the wrong choice, as it would result in panics on misuse. There is probably a better way to do this but I'm not sufficiently familiar with the codebase